dotnet/roslyn

SyntaxGenerator removes DisabledTextTrivia even with "KeepDirectives" is specified

Open

#21,122 创建于 2017年7月25日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBughelp wanted

描述

Consider the following code:

#if SomethingNotSet
    this is disabled code
#endif

    SomeCode();

If you use SyntaxGenerator to remove the "SomeCode();" statement and you specify that you want to keep leading directives, you get the following:

#if SomethingNotSet
#endif

This seems pretty broken. Keeping directives is so that the directives will not be touched and the code will retain its meaning. Here though we remove the DisabledText breaking the intent.

贡献者指南

技术栈
csharp
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# preprocessor directivesRoslyn SyntaxGeneratorTrivia handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Investigate the SyntaxGenerator class to understand how disabled text trivia is handled when KeepDirectives option is used. The issue provides a minimal repro: removing a statement with leading directives causes disabled text to be stripped. Look at the methods related to directive trivia in SyntaxGenerator, and consider adding logic to preserve DisabledTextTrivia when KeepDirectives is specified.