dotnet/roslyn

Always true condition in LocalRewriter_Conversion.cs

Open

#17,839 创建于 2017年3月14日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugConcept-Design Debthelp wanted

描述

Hi there,

On the latest code, the line 23 of LocalRewriter_Conversion.cs contains one bit (&& !wasInExpressionLambda) which is always true and so can be safely removed. Indeed because of the short-circuit if the right part of the expression is reached that means that wasInExpressionLambda is false so !wasInExpressionLambda is always true.

贡献者指南

技术栈
csharp
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with C#basic understanding of boolean logic
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Locate the file `src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter Conversion.cs` in the roslyn repository. At line 23, there is a condition `&& !wasInExpressionLambda` that is always true when reached due to short circuit evaluation. Remove the redundant `&& !wasInExpressionLambda` part, ensuring the logic remains equivalent. No other changes required.
Always true condition in LocalRewriter_Conversion.cs · dotnet/roslyn#17839 | Good First Issue