dotnet/roslyn

Sample unit test code doesnt verify diagnostics at line/column start

Open

#1,641 创建于 2015年3月27日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugTesthelp wanted

描述

The issue is in here and here. If the line/column is 0 unit tests will not care if the expected line/column matches that. Also see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/569.

贡献者指南

技术栈
csharp
领域
testingtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C# basicsunit testing concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue points to two specific lines in DiagnosticVerifier.cs (lines 193 and 204) where the verification of diagnostics fails when line/column is 0. A similar fix was implemented in StyleCopAnalyzers PR #569, which can serve as a reference. The fix should ensure that when line/column is 0, the expected values are still compared. No linked PR or assignees exist, so work can start independently.