dotnet/roslyn
Simplify logic for deconstruction variables in ExpressionVariableFinder
开放
#15,064 创建于 2016年11月7日
Area-CompilersConcept-Design DebtFeature - Tupleshelp wanted
仓库指标
- 星标
- (20,414 个星标)
- PR 合并指标
- (PR 指标待抓取)
描述
Per discussion in PR https://github.com/dotnet/roslyn/pull/14871
- Maybe we don't need
MakeOutVariableandMakeDeconstructionVariable, instead one may suffice, by looking up the syntax tree. - Maybe we don't need
CollectVariablesFromDeconstructioninExpressionVariableFinder, instead we just need aVisitVariableDesignationwhich looks up the syntax tree to determine if it is an out or a deconstruction variable. - Then maybe we can re-use
ExpressionVariableFinderinstead ofForEachLoopBinder.CollectLocalsFromDeconstruction.