dotnet/msbuild

WriteOnlyWhenDifferent should check with the same encoding

Open

#8,361 创建于 2023年1月27日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)C# (5,062 star) (1,364 fork)batch import
Area: TasksPartner requestbackloghelp wantedtriaged

描述

The encoding is missing on the check for WriteOnlyWhenDifferent https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L102 while it's present on the subsequent write: https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L121

贡献者指南

技术栈
csharp
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is located in src/Tasks/FileIO/WriteLinesToFile.cs. The bug is on line 102, where the WriteOnlyWhenDifferent check does not include the encoding parameter, unlike the write on line 121. The fix is to add the encoding parameter to the comparison. The issue has an assignee but no linked PR; check with the assignee or maintainers for current status.