dotnet/msbuild

Add explicit tests around CompareAssemblyIdentity implementation

Open

#5,974 创建于 2020年12月16日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)C# (5,062 star) (1,364 fork)batch import
help wantedtestingtriaged

描述

Before the .NET Core port, ResolveAssemblyReferences compared assembly identities using a native method call:

https://github.com/Microsoft/msbuild/blob/a939f1547a3f8b91512d0d2d270a8d0f0111e7e7/src/XMakeTasks/NativeMethods.cs#L976-L985

Now, there's a managed implementation that optionally calls that one on Windows:

https://github.com/dotnet/msbuild/blob/a8efaf15afcaf5fce9cb6e1c3b7c94e0c88d804b/src/Tasks/NativeMethods.cs#L1114-L1136

We should have tests that validate that implementation using the native method as a reference. This is a nice unit-testing problem since it's functional and idempotent, so we can probably hit 100% code coverage.

Related: #3930, #5973

贡献者指南

技术栈
csharp
领域
build system
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#Unit testingMSBuild codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the managed CompareAssemblyIdentity implementation in src/Tasks/NativeMethods.cs (lines 1114-1136) and the native method reference in src/XMakeTasks/NativeMethods.cs (lines 976-985). Study existing test patterns in the repository to write unit tests that compare outputs. Also review related issues #3930 and #5973 for context.
Add explicit tests around CompareAssemblyIdentity implementation · dotnet/msbuild#5974 | Good First Issue