dotnet/msbuild

Improve log on GenerateResource task

Open

#2,618 创建于 2017年10月10日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C# (1,364 fork)batch import
Area: DebuggabilityArea: Task: GenerateResourcehelp wantedtriaged

仓库指标

Star
 (5,062 star)
PR 合并指标
 (平均合并 11天 7小时) (30 天内合并 125 个 PR)

描述

When investigating on why my incremental build was not that incremental I had a hard time understanding why a specific resource file was always recompiled. It took me hours to download / compile and understand correctly what was goind wrong.

In my case I was hitting: https://github.com/Microsoft/msbuild/blob/a9f64ebd108702c3fc65339c66cb124217854524/src/Tasks/GenerateResource.cs#L1428-L1433

But my file is not missing, the path is only badly formatted: ...\Resources\BuildTagIcon.png (notice the threed dots). For NativeMethodsShared.GetFileAttributesEx it's not valid but it's ok for the resource generator.

We sure can fix this issue but I guess it would be more useful to add some logs. Once I knew which resource was the culprit it was quite easy to understand why.

贡献者指南