dotnet/msbuild

CodeTaskFactory error on missing attributes does not contain element name

Open

#2,072 创建于 2017年5月7日

在 GitHub 查看
 (8 评论) (1 反应) (0 负责人)C# (5,062 star) (1,364 fork)batch import
User Experiencehelp wantedtriaged

描述

When using CodeTaskFactory, if a Reference element is missing the Include attribute, or a Using element is missing the Namespace attribute, an error is printed about an empty attribute value.

This error isn't great for a few reasons

  1. It doesn't say which element the attribute is on
  2. It says "The "Include" attribute has been set but is empty" even when it's missing
  3. It's emitted at the point the task is used, not declared, so the message about the Include attribute is easily confused for referring to the Items passed to the task

贡献者指南

技术栈
csharp
领域
build systemdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#MSBuildXML
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the CodeTaskFactory class in the MSBuild source code to locate where the error messages for missing attributes are generated. Examine the error message formatting to include the element name (e.g., 'Reference' or 'Using') and differentiate between missing and empty attribute values. Review the comments in the issue for additional context and suggested approaches.