dotnet/msbuild

Preprocess flag allows some irrelevant logging to escape

Open

#1,799 创建于 2017年3月6日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (5,062 star) (1,364 fork)batch import
Area: Debuggabilityhelp wantedtriaged

描述

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
    <Target Name="Build" BeforeTargets="bt" AfterTargets="at"/>  
</Project>

msbuild /pp:out.txt test.proj

results in

C:\git\corefx>msbuild /pp:out.txt test.proj
The target "bt" listed in a BeforeTargets attribute at "C:\git\corefx\test.proj (3,26)" does not exist in the project,
and will be ignored.
The target "at" listed in an AfterTargets attribute at "C:\git\corefx\test.proj (3,45)" does not exist in the project,
and will be ignored.
C:\git\corefx>

When using /preprocess, no logging is expected except for cases where /preprocess cannot do its job (for example syntax error or import of nonexistent file)

贡献者指南

技术栈
csharp
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of MSBuildunderstanding of preprocess flag
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the preprocessing code path in MSBuild to identify where logging messages are emitted for non existent targets. The issue is that warnings for BeforeTargets/AfterTargets should be suppressed when /pp (preprocess) flag is used. Look at the ProjectEvaluation or preprocessing logic in the source code (likely under src/Build/ or src/MSBuild/). A fix might involve adding a condition to check if preprocessing is enabled before logging those warnings. The issue has no comments, so the fix can be straightforward.