dotnet/msbuild

[Feature Request]: Reduce the wrapping around SDK Resolver messages when only one resolver is actually invoked

Open

#10,191 创建于 2024年5月30日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)C# (5,062 star) (1,364 fork)batch import
Area: LoggingArea: ResolversFeature RequestGood First IssuePriority:2internal-team-onboardingtriaged

描述

Summary

In https://github.com/dotnet/sdk/pull/41268 I was able to use the SDK Resolver features to ensure that only the NuGet SDK resolver was used for a restore. In this case we should be able to remove MSBuild wrapping around the 'error list' and only surface the single Resolver's message.

Background and Motivation

We want to remove visual noise around error experiences and make it easier for users to diagnose the core problems.

Proposed Feature

https://github.com/dotnet/msbuild/blob/003252215533cca375dfc6578d8cb9e029418f37/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs#L277-L280 should change the way it logs to not log the wrapper if only one resolver was used.

Alternative Designs

No response

贡献者指南

技术栈
csharp
领域
build systemdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#MSBuild build systemSDK resolver
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the referenced code in SdkResolverService.cs around line 277-280 to understand the current wrapping logic. Review the linked SDK PR #41268 to see how the single resolver condition is detected. Propose a change to conditionally log the wrapper only when multiple resolvers were used. Ensure the change maintains backward compatibility and includes appropriate tests.