dotnet/aspnetcore

Add possibility to inject json reviver function in Typescript client

Open

#5,321 创建于 2018年7月26日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)C# (37,933 star) (10,653 fork)batch import
affected-very-fewapi-suggestionarea-signalrenhancementhelp wantedseverity-minor

描述

Currently there is no possibility to customize in any way the behavior of JsonHubProtocol. It could pass a reviver function to the JSON.parse method. If a user could inject such function to the JsonHubProtocol it would be much easier to perform any data transformation (like converting date strings to Date objects).

贡献者指南

技术栈
typescriptjavascript
领域
frontendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptJSON
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the TypeScript client's JsonHubProtocol implementation, likely in the SignalR directory under clients/ts. The goal is to allow users to pass a reviver function to JSON.parse. Start by locating the file that contains the protocol's parse method and understand how JSON is currently deserialized. Then, consider adding an optional reviver parameter to the constructor or parse method, and pass it to JSON.parse. Ensure backward compatibility by making it optional and update the type definitions accordingly. Check existing tests to see how to add test coverage for the new parameter.
Add possibility to inject json reviver function in Typescript client · dotnet/aspnetcore#5321 | Good First Issue