dotnet/aspnetcore
Stop using InvalidOperationExceptions to signal invalid ASCII during parsing
开放
#4,736 创建于 2018年7月19日
affected-very-fewarea-networkingenhancementfeature-kestrelhelp wantedseverity-nice-to-have
仓库指标
- 星标
- (37,933 个星标)
- PR 合并指标
- (PR 指标待抓取)
描述
GetAsciiStringNonNullCharacters() currently throws an InvalidOperationException fo invalid or chacters, and the parsing logic catches these InvalidOperationExceptions at various layers to handle the bad request appropriately.
Ideally we could switch to calling a TryGetAsciiStringNonNullCharacters method, but if propagating failure down the stack proves too difficult, we should at least move to a custom exception type so we don't end up obscuring real product bugs by inadvertently swallowing InvalidOperationExceptions thrown by other methods.