dotnet/aspnetcore

Add configuration option to `RedisCache` to allow read-only access

开放

#38,046 创建于 2021年11月3日

 (2 条评论) (2 个反应) (0 位负责人)C# (10,653 个派生)batch import
area-middlewarefeature-cachinghelp wanted

仓库指标

星标
 (37,933 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Currently, RedisCache resets expiry for keys on every read (https://github.com/dotnet/aspnetcore/blob/main/src/Caching/StackExchangeRedis/src/RedisCache.cs#L293 and in the async version as well).

When using Redis as a session storage, this can lead to sessions getting invalidated unnecessarily on Redis failover. During a new leader election read-only access is preserved which would allow existing clients to continue. However due to the EXPIRE command being issued alongside the read, the read command will fail.

This might be desired behaviour in other circumstances. For a session storage solution it would be fine to just ignore the exception on expire and carry on. In the case that Redis writes do not become available within expiry time, the session would then expire. It would also still expire when attempting other writes.

A configuration option for the cache would be nice to allow expire to fail. Otherwise, changing the variables in the class to protected so sensible overrides are possible might be another solution.

贡献者指南