dotnet/aspnetcore

Write more content directly to StreamWriter in W3CLogger

开放

#33,946 创建于 2021年6月29日

 (6 条评论) (0 个反应) (0 位负责人)C# (10,653 个派生)batch import
Perfarea-networkinghelp wanted

仓库指标

星标
 (37,933 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

See https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r655734742, https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r656445769.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLogger.cs#L49

Since we know the only consumer of this data is StreamWriter, can you delay the Format, enqueue the elements array, and format when writing to the stream? This intermediate string is likely large and useless.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLoggerProcessor.cs#L35

More content that should be written directly to the streamWriter.

贡献者指南