dotnet/aspnetcore

HttpRuleParser GetExpressionLength allows invalid characters.

Open

#2,694 创建于 2018年1月2日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C# (37,933 star) (10,653 fork)batch import
affected-fewarea-networkingbugfeature-http-abstractionshelp wantedseverity-minor

描述

From @jkotalik on Tuesday, August 22, 2017 4:19:40 PM

@Tratcher and I discovered that GetExpressionLength in HttpRuleParser allows invalid characters (including control characters in expressions. GetExpressionLength mentions that we don't really care about the content of a quoted string, however it seems appropriate that if a quoted string has an invalid character, it should throw on parsing here, not in Kestrel (or whatever server).

This would be a breaking change, as it would introduce a new place where an exception is thrown, however it is probably the right behavior.

Copied from original issue: aspnet/HttpAbstractions#923

贡献者指南

技术栈
csharp
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of HTTP parsingC# programming
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is in the GetExpressionLength method in HttpRuleParser.cs. The method currently allows invalid characters in quoted strings. To fix, refer to RFC 7230 for valid characters, and consider adding validation that throws an exception for invalid characters. This is a breaking change, so review existing tests and discuss with maintainers. The file is located at src/Microsoft.Net.Http.Headers/HttpRuleParser.cs.
HttpRuleParser GetExpressionLength allows invalid characters. · dotnet/aspnetcore#2694 | Good First Issue