donnemartin/dev-setup

For all installation scripts, exit immediately if a command exits with a non-zero status

Open

#25 创建于 2016年5月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (5,984 star) (1,162 fork)batch import
enhancementhelp wanted

描述

it's important for a script to exit immediately if a command exits with a non-zero status, otherwise results are unpredictable.

this can be achieved by adding set -e at the beginning of all bash scripts

贡献者指南

技术栈
shell
领域
devopsdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic bash scriptingfamiliarity with git workflow
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue requests adding `set e` to all bash scripts in the repository to ensure they exit on errors. To implement, locate all `.sh` files in the repo (e.g., using `find . name "*.sh"`), then add `set e` at the top of each script after the shebang line. Verify changes by running a few scripts to ensure they behave correctly on failure. The repo is https://github.com/donnemartin/dev setup, and the scripts are likely in the root or a scripts directory.