domaindrivendev/Swashbuckle.AspNetCore
Please annotate SchemaRepository.TryLookupByType
开放
#3,659 创建于 2025年11月15日
good first issuehelp-wanted
仓库指标
- 星标
- (5,496 个星标)
- PR 合并指标
- (平均合并 3天 14小时) (30 天内合并 45 个 PR)
描述
I was reviewing some code and noticed a hidden bug: null could be returned, but there was no compiler warning. This is because TryLookupByType lacks the [NotNullWhen(true)] annotation, which is used, for example, in IPAddress.TryParse.
It would be helpful if SchemaRepository.TryLookupByType were annotated for nullability, similar to my workaround below:
#nullable enable
public static bool TryLookupByTypeSafe(this SchemaRepository schemaRepository,
Type type, [NotNullWhen(true)] out OpenApiSchemaReference? referenceSchema)
{
bool result = schemaRepository.TryLookupByType(type,
out OpenApiSchemaReference? obliviousReferenceSchema);
referenceSchema = result ? obliviousReferenceSchema : null;
return result;
}
#nullable restore
And then the hidden bug becomes a compiler warning: