djenriquez/vault-ui

Confirmation of secret change - Feature request

Open

#101 创建于 2017年4月24日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (1,306 star) (159 fork)batch import
feature requesthelp wanted

描述

First off, great job! I really appreciate the work. Would it be possible to add a confirmation when changing a secret? It seems too easy to accidentally overwrite a secret. This might be more my use case than others, but I have a lot secrets that just get read and I want to avoid them being inadvertently changed when a user is copy/pasting them.

Two ideas:

  1. Just a simple confirmation box before saving
  2. Have the secrets displayed in a modal, non-editable mode which requires clicking an edit button to make changes.

贡献者指南

技术栈
javascriptreact
领域
frontendsecurity
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The feature request proposes adding a confirmation step before saving a secret to prevent accidental overwrites. Two approaches are suggested: a simple confirmation dialog or a modal with an edit button. To implement, examine the current secret creation/editing workflow, likely in a React component such as SecretForm.js or similar. Adding a state variable for editing mode and a confirmation modal component would achieve this. The existing UI patterns for modals in the project can be reused.