fundraising: 'customer.subscription.deleted' webhook event always gets 404 response · django/djangoproject.com#764

(5 评论) (0 反应) (0 负责人)Python (2,001 star) (1,100 fork)user submission

bugfundraisinggood first issue

描述

The response to stripe 'customer.subscription.deleted' webhook event is always 404. The reason is:

In the cancel_donation view, stripe_subscription_id is set to an empty string https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L178

In the subscription_cancelled webhook handler method, the donation object is fetched using stripe_subscription_id which was set to an empty string earlier.

https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L232-L233

So, the response will always be 404 and no cancellation email will be sent to the donor.

贡献者指南

技术栈: python
领域: backendpayments
议题类型: bug
难度: 3
预计时间: under 1 hour
活动状态: stale
清晰度: clear
前置要求: DjangoStripe APIPython
新手友好度: 70
研究方向: The bug is in fundraising/views.py. In the cancel donation view, stripe subscription id is set to an empty string at line 178. The subscription cancelled webhook handler at lines 232-233 uses that empty id to fetch the donation, resulting in a 404. To fix, ensure the subscription id is retained until after the webhook is processed, or handle the case where the subscription id is cleared. This is a small localized change that a newcomer can implement.