Cannot switch back from pre-defined benefit/condition to a non-pre-defined one · django-oscar/django-oscar#3889

(4 评论) (0 反应) (0 负责人)Python (5,871 star) (2,156 fork)batch import

Good first issue☁ Bug

描述

The current benefit and condition forms don't work properly when switching back to using a non-pre-defined benefit/condition from a pre-defined one.

Create an offer with a non-pre-defined benefit or condition.
Go to the benefit/condition form for that offer and change it to a pre-defined one.
Go back to the form and try to change it back to a non-pre-defined one.
Instead of switching back, the benefit/condition is still referencing the previous pre-defined one.

On the public sandbox, the form only has pre-defined benefits, but the saving logic is identical and the bug is also present in the ConditionForm as well: https://github.com/django-oscar/django-oscar/blob/04dd391c900537a61dbb0ae5250ca5c2df6bbc4b/src/oscar/apps/dashboard/offers/forms.py#L137-L143
After switching to a pre-defined benefit/condition, the form also displays the other field data that had to be removed back in step 2.

技术栈: pythondjango
领域: backend
议题类型: bug
难度: 2
预计时间: 1-3 hours
活动状态: stale
清晰度: clear
前置要求: Basic PythonDjango forms
新手友好度: 60
研究方向: The bug is in the benefit/condition form logic at src/oscar/apps/dashboard/offers/forms.py lines 137-143. Investigate how switching between pre defined and non pre defined benefits preserves the previous selection. Look at the handling of the benefit choice field and how it interacts with the form's save method. The issue also mentions that after switching to pre defined, the form displays other field data that should have been removed. A fix likely involves clearing or resetting dependent fields when the type changes.