diesel-rs/diesel

First Rust example code on the website is unidiomatic

Open

#2,451 创建于 2020年7月6日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)Rust (12,054 star) (1,003 fork)batch import
documentationhelp wanted

描述

The first Rust code example, also available under examples/postgres/getting_started_step_1, is using .ok(); to discard the error case of a Result. If ignoring any errors is intentional, that line should be updated from

dotenv().ok();

to

let _ = dotenv();

Otherwise, the .ok() should be replaced by something else (maybe .expect("dotenv setup to be successful")).

Checklist

  • I have already looked over the issue tracker for similar issues.
  • This issue can be reproduced on Rust's stable channel. (Your issue will be closed if this is not the case) N/A

贡献者指南

技术栈
rust
领域
documentation
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
The issue is to update the first Rust example code in `examples/postgres/getting started step 1/src/lib.rs`. The current line `dotenv().ok();` should be changed to either `let = dotenv();` or `dotenv().expect("dotenv setup to be successful");`. The contributor should open a pull request making this change. No additional investigation is needed beyond reading the issue and the linked file.
First Rust example code on the website is unidiomatic · diesel-rs/diesel#2451 | Good First Issue