dice-roller/rpg-dice-roller

Issues with module's types

开放

#247 创建于 2022年4月1日

 (4 条评论) (0 个反应) (0 位负责人)JavaScript (68 个派生)auto 404
bughelp wanted

仓库指标

星标
 (279 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Describe the bug Some of the type definitions seems to be faulty or incomplete.

To Reproduce Steps to reproduce the behaviour:

  1. Bootstrap a new typescript project with the defaults (npm i typescript --save-dev && npx tsc --init)
  2. Install the module via npm (npm install @dice-roller/rpg-dice-roller)
  3. Create an example file index.ts (see below)
  4. Set skipLibCheck to false in tsconfig.json
  5. Run tsc to build the project

Expected behaviour No type errors show up.

Code snippet

import { DiceRoll } from "@dice-roller/rpg-dice-roller"

const roller = new DiceRoll("6d6")

console.log(roller.toString())

Environment:

  • Node.js 17.3.0 on Windows 10 & Node.js 16.14.2 on Ubuntu 20.04.4 installed from nodesource
  • Module version 5.1.0, 5.0.0 has the same behaviour

贡献者指南