diasurgical/DevilutionX

Refactor 31 lines occurring 2 times in 2 files: drlg_l2.cpp, drlg_l4.cpp

开放

#1,997 创建于 2021年5月17日

 (6 条评论) (0 个反应) (0 位负责人)C++ (743 个派生)batch import
good first issuehelp wanted

仓库指标

星标
 (7,255 个星标)
PR 合并指标
 (平均合并 2天 12小时) (30 天内合并 15 个 PR)

描述

I've selected for refactoring 31 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖 Do not copy code.
  • Why❓ When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
  • How 🔧 Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖


Good luck and happy coding! :shipit: :sparkles: :100:

贡献者指南