diasurgical/DevilutionX
Refactor devilution.DefaultClass::CheckInvPaste(int, int, int)
开放
#1,996 创建于 2021年5月17日
good first issuehelp wanted
仓库指标
- 星标
- (7,255 个星标)
- PR 合并指标
- (平均合并 2天 12小时) (30 天内合并 15 个 PR)
描述
I've selected devilution.DefaultClass::CheckInvPaste(int, int, int) for refactoring, which is a unit of 362 lines of code and 135 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍
Here's the gist of this guideline:
- Definition 📖 Limit the number of branch points (if, for, while, etc.) per unit to 4.
- Why❓ Keeping the number of branch points low makes units easier to modify and test.
- How 🔧 Split complex units with a high number of branch points into smaller and simpler ones. This one in particular has a big switch that could probably be split out in to sub-functions.
You can find more info about this guideline in Building Maintainable Software. 📖
Good luck and happy coding! :shipit: :sparkles: :100: