developit/workerize-loader

Fails when a depedency (module) requires a webpack "external" module

Open

#22 创建于 2018年2月14日

在 GitHub 查看
 (3 评论) (4 反应) (0 负责人)JavaScript (2,296 star) (111 fork)batch import
help wantedquestion

描述

Awesome library! I've just found an edge case when workerizing a module that depends on a webpack external.

In my webpack config i have:

module.exports = {
  // ...
  externals: {
    'config': JSON.stringify(config),
  },
  // ...
}

and in my worker module I have:

import * as config from 'config';

I'm using typescript in case that matters.

Here's the compilation error from webpack:

Module not found: Error: Can't resolve 'config' in '/directory/src'
 @ ./src/MyWorker.ts 1:0-33

贡献者指南

技术栈
javascripttypescript
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
webpackworkerize loaderTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the workerize loader source code, particularly the part that resolves dependencies for the worker. The issue is that webpack externals are not passed to the worker bundle. A possible fix is to include the externals configuration in the worker's webpack config or to alias them. Look at the loader's implementation in src/loader.js (or similar) and the test directory for existing tests.