developit/preact-redux

preact-redux 2.1.0 not working with preact-router when passing route values

Open

#47 创建于 2019年6月14日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (26 fork)github user discovery
bughelp wantedlegacy

仓库指标

Star
 (287 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

First I would like to note: PREACT is fantastic, that is why we have put forth great effort to continue using it.

Our app is now lightning fast due to the great work at PREACT, PREACT-REDUX and the PREACT-CLI – keep it up!!.

We had a very similar issue to this so we decided to post an example hoping that the owners of PREACT-REDUX will see it clearly, and have a fast path to remedy.

First I created the “brandnew” app (brandnew.zip) (using preact-cli version 2.2.1)

  • preact create default brandnew

I then created a simple example that would work, DemoIssue and AnotherComponent are the two components that should display what is given in the route parameters when the links Demo 1 or Demo 2 are clicked.

Alas it works :)

Then I added redux to the mix

  • npm install redux --save
  • npm install preact-redux –save
  • npm install preact-context –save (This can be removed later..read on)

This installs preact-redux: “^2.1.0

I then added a simple example of wiring up to redux (Nothing fancy, just a counter to prove it works).

Alas it is broken, hmmmm?

At this point in the app, I could comment out the redux connect in demo-issue.js and simply use the “export default DemoIssue” and it would still work, however we really need redux…

After trial and error we figured out that if we revert to preact-redux 2.0.3 – NOT preact-redux ^2.0.3 – the app works as expected!!!.

Now that we have gone back to 2.0.3 you can safely remove preact-context as it is no longer a dependency.

Hope that helps in figuring out what is really wrong.

贡献者指南