delta-io/delta

[Kernel][Testing] Add more thorough testing for DataType.toJson

Open

#2,313 创建于 2023年11月20日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Scala (8,807 star) (2,100 fork)batch import
enhancementgood first issuekernel

描述

Feature request

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Overview

All of our DataType classes provide toJson which serializes the type following the delta protocol schema serialization rules https://github.com/delta-io/delta/blob/master/PROTOCOL.md#schema-serialization-format. We use this method to serialize the physical and logical schemas in ScanStateRow.

toJson is only tested by the 2 round-trip tests in DefaultJsonHandlerSuite. We should add more thorough tests for toJson.

贡献者指南

技术栈
无
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Scala or Java programmingDelta protocol schema serializationExisting test suite structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Start by examining the existing `DefaultJsonHandlerSuite` to understand the current round trip tests for `toJson`. Then identify all `DataType` subclasses and ensure each has a test case that verifies the serialization matches the Delta protocol schema serialization format. Pay attention to edge cases like nested types. Refer to the protocol specification at https://github.com/delta io/delta/blob/master/PROTOCOL.md#schema serialization format for exact rules.