decentralized-identity/ion

CLI creates payload is outdated key type

Open

#229 创建于 2021年9月7日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)HTML (1,219 star) (168 fork)batch import
good first issuehigh prioirtyimprovement

描述

As of

  "name": "ion",
  "version": "1.0.3",

{
        "action": "replace",
        "document": {
          "publicKeys": [
            {
              "id": "signing-key",
              "type": "EcdsaSecp256k1VerificationKey2019",
              "publicKeyJwk": {
                "kty": "EC",
                "crv": "secp256k1",
                "x": "qp0Ezzc4YhA196COYKa-RHrCom-0LgFtAf8FqvcntN0",
                "y": "zWcbbbg9w1m-DNOszvM68TD0_vFBtWyc18S06c8cULU"
              }
            }
          ]
        }
      }

Should be

{
        "action": "replace",
        "document": {
          "publicKeys": [
            {
              "id": "signing-key",
              "type": "JsonWebKey2020",
              "publicKeyJwk": {
                "kty": "EC",
                "crv": "secp256k1",
                "x": "qp0Ezzc4YhA196COYKa-RHrCom-0LgFtAf8FqvcntN0",
                "y": "zWcbbbg9w1m-DNOszvM68TD0_vFBtWyc18S06c8cULU"
              }
            }
          ]
        }
      }

This is low priority, but will harm interoperability with JsonWebSignature2020, better not to encourage that key type to be used.

贡献者指南

技术栈
无
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JSON syntaxfamiliarity with ION CLI
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue is to change a hardcoded key type string in the CLI code that generates the payload. Locate the template or function that outputs the JSON with 'EcdsaSecp256k1VerificationKey2019' and replace it with 'JsonWebKey2020'. The code is in the ION repository, likely under a directory for the CLI (e.g., packages/cli). The relevant file may be something like 'create payload.ts' or similar. The change is trivial and well described in the issue.