db-migrate/node-db-migrate

EventEmitter memory leaks

Open

#421 创建于 2016年10月4日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (2,296 star) (367 fork)batch import
Refactoringgood first issuehelp wanted

描述

When using db-migrate programmatically for multiple databases, warnings are generated for EventEmitter leaks: Warning: Possible EventEmitter memory leak detected. 11 unhandledRejection listeners added.

Adding a unregisterEvents function to api.js should enable programmatic users to get around this. Such a function may also be used more generally to do proper cleanup.

Where registerEvent() is called: https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L136-L147

Where registerEvents() is defined: https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L136-L147

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

贡献者指南

技术栈
javascript
领域
backenddatabase
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic Node.js knowledgeUnderstanding of EventEmitter
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
First, study the existing `registerEvents` function in `api.js` (lines 136-147) to understand how event listeners are added. Then, design an `unregisterEvents` function that removes those listeners. Consider using `removeListener` or `removeAllListeners` for specific events. Finally, implement the function and export it from the module. No existing PR or comments provide a solution, so this is a clean feature addition.
EventEmitter memory leaks · db-migrate/node-db-migrate#421 | Good First Issue