davidtheclark/no-scroll

Previous styles on documentElement are not restored

Open

#10 创建于 2019年1月2日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)HTML (13 fork)github user discovery
bughelp wanted

仓库指标

Star
 (244 star)
PR 合并指标
 (PR 指标待抓取)

描述

I had a use case where the documentElement had inline styles on it, like so: <html style="padding: 0; margin: 0; overflow-x=hidden;">. I noticed that after toggling no-scroll to off, the overflow-x=hidden was being wiped out. After checking the code in no-scroll, I found that it's hard-coding the style attributes when off() is called. I think that no-scroll should be restoring whatever values were set before on() was called, instead of overwriting them.

贡献者指南