cython/cython

public and api generate invalid header files when types aren't builtin in C

Open

#1,800 创建于 2017年7月28日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (8,663 star) (1,517 fork)batch import
Code GenerationP: minordefecthelp wanted

描述

If I did this in test.pyx:

from libcpp.string cimport string

cdef public api string t(string s):
    return string()

the generated header files must be included after as they use std::string but don't include it.

贡献者指南

技术栈
pythonccpp
领域
toolingbuild system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Cython's C++ interopFamiliarity with C++ headers
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is that Cython's header generation for public api functions using C++ types (e.g., std::string) does not include the necessary C++ headers. The fix likely involves modifying the code generation logic in Cython (e.g., in Cython/Compiler/Code.py) to emit #include directives for C++ standard library headers when such types are used. Investigating the current header generation for public api functions and ensuring that the generated .h files include the appropriate headers (like <string>) would resolve the bug.