cube-js/cube

Align `TableColumn` Type with `Annotation` (Client Core)

Open

#9,976 创建于 2025年9月17日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
client:corehelp wanted

描述

Is your feature request related to a problem? Please describe.

We have two related types (as I believe table columns are derived from the annotation data):

https://github.com/cube-js/cube/blob/0fde75d3975d6911ec67353dacb9cfa0f62f0096/packages/cubejs-client-core/src/types.ts#L18-L27

https://github.com/cube-js/cube/blob/0fde75d3975d6911ec67353dacb9cfa0f62f0096/packages/cubejs-client-core/src/types.ts#L304-L313

I'm wondering why the types for type and format are different? I feel like Annotation is the correct one?

Describe the solution you'd like

Update the TableColumn type to better match Annotation.

Describe alternatives you've considered

N/A

Additional context

N/A

贡献者指南

技术栈
typescript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
TypeScriptCube.js client core
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Examine the types defined in packages/cubejs client core/src/types.ts lines 18-27 and 304-313. Determine the field differences between TableColumn and Annotation. Update TableColumn type to use the same type and format patterns as Annotation. Ensure consistency and consider if any other types rely on TableColumn.