cube-js/cube

@cubejs-client/core load method error does not contain HTTP error code

Open

#833 创建于 2020年7月14日

在 GitHub 查看
 (4 评论) (6 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
client:corehelp wanted

描述

Describe the bug In @cubejs-client/core, when an errors occurs, there is no way to get errors the HTTP error code.

To Reproduce

  1. Make a request using @cubejs-client/core like this
const makeQuery = async () => {
  const cubejsApi = cubejs(
    'CUBEJS-API-TOKEN',
    { apiUrl: 'http://localhost:4000/cubejs-api/v1' }
  );

  try {
    const response = await cubejsApi.load(query);
    return response.chartPivot();
  } catch (error) {
    console.log(error);
  }
}
  1. error in the catch block does not contain http error code

Expected behavior error should contain the HTTP error code

Version: ^0.15.4

Additional context

贡献者指南

技术栈
javascripttypescript
领域
apideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptHTTP basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The error object in the catch block does not include the HTTP status code. Look at the `load` method in the client code (likely in `packages/cubejs client core/src/index.js` or similar). The error is likely thrown from an HTTP request; ensure the response status is passed to the error. Check the error handling logic and modify it to include `error.httpStatus` or similar. See also related comments in the issue for additional context.