cube-js/cube

There should be a way to cancel the requests from useCubeQuery when the component has unmounted

Open

#8,263 创建于 2024年5月15日

在 GitHub 查看
 (3 评论) (3 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
client:coreclient:reacthelp wanted

描述

When we are using the useCubeQuery hook to get the data from cube server & user has routed to some other routes, while the result is being fetched. Then it should cancel out the request , as component from which the request was raised has already unmounted

To Reproduce Steps to reproduce the behavior:

  1. create a dashboard with multiple reports on it
  2. redirect to another route as soon as you have landed on dashboard
  3. In network tab of developer tool, you will see that the requests of reports on dashboard are still active, which is of no use now, as the dashboard component has already unmounted

Expected behavior Requests for reports data should have be cancelled out

贡献者指南

技术栈
reactjavascripttypescript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React hooksJavaScript async/await
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests that useCubeQuery cancel pending requests on component unmount. The fix likely involves adding an AbortController or similar mechanism within the hook. Look at the source code in packages/cubejs react/src/hooks/ or similar. There are 3 comments and no open PRs. Check if maintainers have provided any guidance in comments. The expected behavior is clear, but the exact implementation may need approval.