cube-js/cube

Pre-aggregations with elasticsearch as datasource are not timezone aware

Open

#7,700 创建于 2024年1月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
driver:elasticsearchhelp wanted

描述

When creating pre-aggregations with different time zones and elasticsearch as a data source, the time dimension of the results is not converted to each applicable time zone because 'convertTz' is not implemented in the "ElasticSearchQuery" adapter. The convertTz function code can be as follows:

public convertTz(field: string): string {
    const tz = moment().tz(this.timezone);
    // TODO respect day light saving
    const [hour, minute] = tz.format('Z').split(':');
    const [hourInt, minuteInt] = [parseInt(hour, 10), parseInt(minute, 10) * Math.sign(parseInt(hour, 10))];
    let result = field;
    if (hourInt !== 0) {
      result = `TIMESTAMPADD('hour', ${hourInt}, ${result})`;
    }
    if (minuteInt !== 0) {
      result = `TIMESTAMPADD('minute', ${minuteInt}, ${result})`;
    }
    return result;
}

贡献者指南

技术栈
javascripttypescriptnodejselasticsearch
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptElasticsearch query syntaxmoment.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue involves implementing the convertTz function in the ElasticSearchQuery adapter. Locate the adapter file (likely in packages/cubejs elasticsearch driver/src/ElasticSearchQuery.ts). Follow the pattern from other adapters' convertTz implementations, using moment.js to apply timezone offset via TIMESTAMPADD. Ensure daylight saving time is handled and the function integrates with existing pre aggregation logic. No existing PRs; the maintainers have not clarified scope, so the implementation should be straightforward.
Pre-aggregations with elasticsearch as datasource are not timezone aware · cube-js/cube#7700 | Good First Issue