cube-js/cube

Need base Path for health-checks

Open

#4,808 创建于 2022年6月27日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
help wantedloggedreviewed

描述

Is your feature request related to a problem? Please describe.

Hi I am currently deploying Cubejs behing Nginx Proxy so I should add prefix path to the Node. As the basePath configuration works very well for /v1/load, I could not hit health-checks related endpoint, since the Nginx controller will re-route the request incorrectly.

Describe the solution you'd like I was wondering, could we add /basePath prefix to livez and readyz ?. Is there any specific consideration why we did not set this up in the first place ?

Other Endpoint References

Requested Endpoints to change

贡献者指南

技术栈
javascriptnodejsrest api
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScript/Node.jsunderstanding of health checksfamiliarity with CubeJS basePath
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Examine the CubeJS repository for health check endpoint definitions (e.g., `livez` and `readyz`). Look at how `basePath` is applied to other routes like `/v1/load`. The change involves adding the `basePath` prefix to these health check routes. Reference the issue comments for any additional context. The implementation is likely in a route definition file; search for 'livez' or 'readyz' in the codebase.