`shouldFetchDryRun` should consider changes made to filters · cube-js/cube#3552

(1 评论) (0 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import

client:reacthelp wanted

描述

Describe the bug When I modify filters using updateFilters methods within QueryBuilder, a dry run does not occur as expected. Adding filters to the existing shouldFetchDryRun array (['measures', 'dimensions', 'timeDimensions']) fixes the issue.

To Reproduce Steps to reproduce the behavior:

Call updateFilters.add QueryBuilder (@cubejs-client/react) to modify filters
A dry run does not occur

Expected behavior I expect a filter change to prompt a dry run.

Screenshots https://github.com/cube-js/cube.js/blob/master/packages/cubejs-client-react/src/QueryBuilder.jsx#L485-L488

Version: 0.28.43

Additional context Add any other context about the problem here.

贡献者指南

技术栈: javascriptreactnodejs
领域: frontend
议题类型: bug
难度: 2
预计时间: under 1 hour
活动状态: fresh
清晰度: clear
前置要求: knowledge of Reactfamiliarity with cubejs client
新手友好度: 80
研究方向: The issue is located in packages/cubejs client react/src/QueryBuilder.jsx around line 485-488. The fix is to add 'filters' to the array ['measures', 'dimensions', 'timeDimensions'] in the shouldFetchDryRun function. No additional changes are needed; it's a simple array addition.