cube-js/cube

Elasticsearch - Result formatting differences

开放

#2,663 创建于 2021年5月6日

 (3 条评论) (0 个反应) (0 位负责人)Rust (1,965 个派生)batch import
community supporteddriver:elasticsearchhelp wanted

仓库指标

星标
 (19,563 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

A recent change to conform with elaastic.co result formatting (to cope with json result) is not compatible with open distro/aws es sql result formatting. In open distro case, json formatting is more like the standard es result format whereas json format in elastic.co is more like a jdbc format.

This is the offending code. https://github.com/cube-js/cube.js/blob/c1e25d7184c5ed63ba083da1cd9cf0f2111b8011/packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js#L86

We perhaps need to split the driver in some way - either entirely or certainly the query and driver.

I am happy to look at PR for this

To Reproduce setting result format to json while using awses/open distro - json result formatting results in an exception

Expected behavior Both open distro and elastic.co should be supported either via single driver or multiple

Version: latest

贡献者指南