cube-js/cube

Elasticsearch - Result formatting differences

Open

#2,663 创建于 2021年5月6日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Rust (1,965 fork)batch import
community supporteddriver:elasticsearchhelp wanted

仓库指标

Star
 (19,563 star)
PR 合并指标
 (平均合并 5天 16小时) (30 天内合并 138 个 PR)

描述

A recent change to conform with elaastic.co result formatting (to cope with json result) is not compatible with open distro/aws es sql result formatting. In open distro case, json formatting is more like the standard es result format whereas json format in elastic.co is more like a jdbc format.

This is the offending code. https://github.com/cube-js/cube.js/blob/c1e25d7184c5ed63ba083da1cd9cf0f2111b8011/packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js#L86

We perhaps need to split the driver in some way - either entirely or certainly the query and driver.

I am happy to look at PR for this

To Reproduce setting result format to json while using awses/open distro - json result formatting results in an exception

Expected behavior Both open distro and elastic.co should be supported either via single driver or multiple

Version: latest

贡献者指南