cube-js/cube

@cubejs-client/core load / drilldown load method requires supports for pagination like `page`, `per_page`, to improve performance

Open

#1,434 创建于 2020年11月24日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)Rust (19,563 star) (1,965 fork)batch import
client:corehelp wanted

描述

Is your feature request related to a problem? Please describe. When using a drilldown load query, the number of records returned from db can be in the order or thousands or millions of records depending on the implementation and use-case. This can affect the performance of database server and can momentarily cause huge performance issues the database server.

Describe the solution you'd like drilldown query should ideally support page, per_page, other than limit .

Describe alternatives you've considered No alternatives found as of now

Additional context

  1. records recieved in the order of thousands or millions can be pginated at front-end side, but the performance is affected very badly at the db side. This is a huge concern for the product team. Not able to go for deployment.
  2. offset is not enough to build a pagination ui, it gives a very bad UX

贡献者指南

技术栈
javascripttypescriptnodejs
领域
performancebackendanalytics
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Cube.js client load methodFamiliarity with pagination patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the existing 'load' method in '@cubejs client/core' (likely in 'packages/cubejs client core/src' directory). The issue requests adding 'page' and 'per page' parameters alongside existing 'limit'. Review any related discussions in comments; no linked PRs exist. Investigate how 'limit' is currently passed to the API and consider extending the query builder to support offset/pagination without degrading performance. Look for existing tests for the load method to understand expected behavior.