cssinjs/jss

UMD builds not working on import

Open

#1,567 创建于 2021年10月21日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:lowhelp wanted

描述

Expected behavior: I'm trying to implement react-jss via CDN. Importing the UMD build via <script> tag should work out of the box.

Describe the bug: The module does not load and the console generates the error as follows:

Uncaught ReferenceError: module is not defined
    at react-jss.min.js:6
    at react-jss.min.js:1
    at react-jss.min.js:1

Reproduction:

CodeSandbox - loading react, react-dom, and react-jss

Versions:

  • jss: 10.8.1
  • browser: any

贡献者指南

技术栈
javascriptreact
领域
frontendbuild system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of UMD module formatBasic bundler configuration knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue is that the UMD bundle for react jss references `module` which is not defined in the browser. Investigate the Rollup configuration (likely `rollup.config.js` or `package.json` build scripts) to see how the UMD output is generated. Look for any missing `output.globals` or improper use of CommonJS. The fix may involve ensuring the bundle does not depend on `module` or adding a shim. Check the existing build setup and compare with other packages that successfully produce UMD bundles.
UMD builds not working on import · cssinjs/jss#1567 | Good First Issue