cssinjs/jss

TS error using a function to customise defaults with the default unit plugin

Open

#1,444 创建于 2021年1月20日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
help wantedtypescript

描述

Expected behavior: Use the 'jss-plugin-default-unit' to override default units for numeric values in combination with TypeScript.

Describe the bug: The plugin itself doesn't appear to have any issues but I am receiving TypeScript related errors in my IDE when using a function to define an option for the plugin.

const options = {
    width: val => `${val / 2}px`
}
jss.use(defaultUnit(options));

Source: https://cssinjs.org/jss-plugin-default-unit/?v=v10.5.0#customizing-defaults

I'm not sure if the following is the cause but the two definitions of the Options type do not seem to match:

Codesandbox: N/A

Versions:

  • react-jss: 10.5.0
  • typescript: 4.0.3
  • OS: Linux

贡献者指南

技术栈
typescriptjavascriptcss
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript typesJSS plugin system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Examine the two files: packages/jss plugin default unit/src/index.js and packages/jss plugin default unit/src/index.d.ts. The Options type in the .d.ts may need to accept a function type for default values. Check the JssStyle type and ensure consistency. No existing PRs or comments provide additional guidance.