cssinjs/jss

Previous styles not being removed when returning 'null' values using dynamic rule sets.

Open

#1,421 创建于 2020年11月7日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

NOTE: Similar to https://github.com/cssinjs/jss/issues/1026, but with dynamic rule sets instead of dynamic values.

Just to clarify nomenclature... dynamic rule set Vs. dynamic value:

{
  // DYNAMIC RULE SET
  a: ({color}) => ({
    display: 'inline',
    color: color
  }) ,
  b: {
    display: 'inline',
    // DYNAMIC VALUE
    color: ({ color }) => color
  }
}

Expected behavior: Previous applied values to be removed when respective value is set to null in a dynamic rule set.

Describe the bug: Previous values are not removed causing a number of trouble.

Codesandbox link: https://codesandbox.io/s/fervent-dawn-uomkr

Versions:

  • JSS: 10.4.0
  • Browser: All
  • OS: macOS 10.15.7

贡献者指南

技术栈
javascriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with JSS APIUnderstanding of dynamic rule sets vs dynamic values
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the JSS source code for handling dynamic rule sets, particularly the updatePath logic. Compare with dynamic values handling. The codesandbox provides a minimal reproduction. Investigate why null values do not trigger removal of previous styles. Look at related issue #1026 for context.