cssinjs/jss

themed useCreateStyles creates className mismatch when hydrating in StrictMode

Open

#1,338 创建于 2020年4月26日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

Expected behavior: className matches during hydration

Describe the bug: The counter in the className is off by one

Codesandbox link: https://codesandbox.io/s/createusestyles-classname-mismatch-zdojq?file=/src/App.js

The useLayoutEffect warnings are false positives since we SSR in the browser to showcase the issue better. Versions (please complete the following information):

  • jss: 10.1.1
  • Browser [e.g. chrome, safari]: Chrome 81
  • OS [e.g. Windows, macOS]: ubuntu 18.04
  • react: 16.13.1

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React hydration knowledgeCSS in JS basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the className counter logic in JSS's createUseStyles hook, likely in packages/jss/src/createUseStyles.js. The codesandbox demonstrates a mismatch during hydration, so focus on how class names are generated and incremented across server and client renders. Check if the counter resets incorrectly in React StrictMode double rendering.