cssinjs/jss

createUseStyles + @media + Adapting based on props: not updating correctly

Open

#1,327 创建于 2020年4月7日

在 GitHub 查看
 (7 评论) (2 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

Expected behavior: When a property is changed, styles that are inside a @media selector are not being re-generated.

Describe the bug: When a property is changed, all styles that are properties-dependent should be re-generated and re-applied to the component.

Steps:

  1. "Swap color" button loads with background red and border/text-shadow blue
  2. Click on the "Swap color" button
  3. Background is changed to "blue" ✅
  4. Text-shadow is changed to "red" ✅
  5. Border is kept "blue" ❌

Codesandbox link: https://codesandbox.io/s/createusestyles-media-vf5zs

Versions (please complete the following information):

  • react-jss: 10.1.1
  • Browser [e.g. chrome, safari]: chrome (but all)
  • OS [e.g. Windows, macOS]: macOs (but all) Feel free to add any additional versions which you may think are relevant to the bug.

贡献者指南

技术栈
javascriptreactcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactCSS media queriesreact jss basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the react jss hook `createUseStyles` and how it handles dynamic props inside `@media` queries. Examine the source code in `react jss/src/hooks/create use styles.js` to understand the re evaluation logic. Use the provided codesandbox reproduction to test. Look for any missed dependencies or missing updates when props change within media queries. Check the JSS core library for how `@media` rules are processed. Review comments in the issue for potential insights.