cssinjs/jss

Using arrow function on jss-rtl dependent property does not works well

Open

#1,234 创建于 2019年11月21日

在 GitHub 查看
 (10 评论) (4 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

Expected behavior:

The rtl plugin should switch the styles.

Describe the bug:

The rtl plugin doesn't switch all the styles.

const useStyles = createUseStyles({
  myButton1: {
    paddingLeft: "16px" ✅
  },
  myButton2: {
    paddingRight: ({ isMobile }) => (isMobile ? 0 : "26px") ❌
  },
  myLabel: props => ({
    paddingRight: "8px" ✅
  })
});

Codesandbox link:

https://codesandbox.io/s/react-jss-playground-37lqs

Versions (please complete the following information):

  • jss: 10.0.0
  • Browser [e.g. chrome, safari]: all
  • OS [e.g. Windows, macOS]: all

First reported in https://github.com/mui-org/material-ui/issues/18477.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptJSS basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the jss rtl plugin source code, likely in packages/jss rtl/src. Look for how it processes style objects and specifically handles function values (arrow functions that return objects or values). Compare with how static values are flipped. The issue shows that function based values are not being transformed. Check if there's a missing check or transformation step for function values. Review linked PRs or comments for any proposed fix. Consider adding a test case similar to the bug report.