cssinjs/jss

react-jss: Observables issue

Open

#1,193 创建于 2019年9月17日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

Expected behavior: Observables should not change the {link: true} to {link: false}

Describe the bug: If Observable's internal method is enumerable, then react-jss considers it a dynamic style and adds an unnecessary empty class. On the other hand, if the method is not enumerable, then the empty class is not added, but it does not link the styles and observable styles do not work.

Codesandbox link: https://codesandbox.io/s/react-jss-v1000alpha-25-observable-issue-g8998

Versions (please complete the following information):

  • jss: 10.0.0-alpha.25
  • Browser [e.g. chrome, safari]: Chrome
  • OS [e.g. Windows, macOS]: Windows

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactJSSObservables
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the interaction between react jss and observable objects. Examine the code in react jss that detects dynamic styles (likely in `useStyles` or style observation logic). The issue mentions that if observable's internal method is enumerable, an unnecessary empty class is added; if not enumerable, styles are not linked. The linked CodeSandbox should be used to reproduce. A possible fix could involve checking for observable objects differently, perhaps by using a weak map or not relying on enumerability.