cssinjs/jss

[core] sheet.addRule with media query after attachment

Open

#1,038 创建于 2019年2月17日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:highhelp wanted

描述

Expected behavior: I should be able to create a style sheet, attach it to the dom and add a rule to a media query rule.

Describe the bug: Currently, the rule is added virtually but isn't rendered.

Codesandbox link: https://codesandbox.io/s/w66v8p8m35

Versions (please complete the following information):

  • jss: 9, 10
  • Browser chrome
  • OS macOS

贡献者指南

技术栈
javascriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of JSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the `sheet.attach()` and `sheet.addRule()` methods in JSS source code to understand why rules added after attachment are not rendered in the DOM. The provided codesandbox reproduces the issue; focus on how rules are inserted into the style element and why media query rules might be skipped. Look at the `insertRule` function and the `toCSS` method for media queries.