csnover/TraceKit

Fix flakey tests

Open

#77 创建于 2020年4月8日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (1,017 star) (174 fork)batch import
bughelp wanted

描述

There are five flakey tests that have to do with ensuring the window.onerror is called and works properly. This needs to be mocked or figure out why the test occasionally hangs.

      - should pass undefined:undefined...
log: window.onerror(undefined, undefined, 1337, undefined)

log: matches test message and line number
       X should pass undefined:undefined
         Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) (1)
>> Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
>>     at <Jasmine>
     when no 5th argument (error object)

贡献者指南

技术栈
javascript
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScript basicsJasmine testingunderstanding of async behavior
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the test files for 'window.onerror' functionality, likely in the test suite. The issue mentions tests hang due to async timeouts, so mocking 'window.onerror' or adjusting timeout settings might fix. Look at other test patterns in the repo to see how similar async tests are handled.