crytic/slither

slither-read-storage: add support for nested structs

Open

#2,077 创建于 2023年8月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (4,769 star) (886 fork)batch import
enhancementgood first issue

描述

For example: https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/e6e6d73c6219a9e436cdc91ac4f943c7699831c0/contracts/utils/structs/EnumerableSetUpgradeable.sol#L233-L235

This needs to be updated to calculate the slot for UserDefinedType https://github.com/crytic/slither/blob/3f90e86badfa956b5cc692e0421c2b8065c31d43/slither/tools/read_storage/read_storage.py#L593

Test case slither-read-storage bsc:0x52Dcd80506bc421cae6927C73f306FD0d083e43a

贡献者指南

技术栈
python
领域
toolingcli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonSolidity storage layoutUnderstanding of slither read storage
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requires modifying the function at slither/tools/read storage/read storage.py line 593 to handle UserDefinedType for nested structs. The test case 'slither read storage bsc:0x52Dcd80506bc421cae6927C73f306FD0d083e43a' can be used to verify the change. Look at the linked code in openzeppelin contracts upgradeable for an example of nested struct usage. No maintainer clarification is needed.