crytic/slither

[Bug]: all statements with `.` are reported as external calls

Open

#2,073 创建于 2023年8月1日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (4,769 star) (886 fork)batch import
buggood first issue

描述

Describe the issue:

I ran slither . --print function-summary to view external calls for functions. The resulting "External Calls" column treats any statement with a . as an external call. This includes solidity built-ins like abi.encode, library accesses like Address.sendValue, and struct field accesses.

Code example to reproduce the issue:

git clone https://github.com/scopelift/pooltogether-governor-upgrade/
cd pooltogether-governor-upgrade
forge install
slither . --print function-summary

Version:

0.9.6

Relevant log output:

No response

贡献者指南

技术栈
python
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonSolidity syntaxStatic analysis concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Examine the function summary printer in `slither/printers/` to see how external calls are identified. Look for logic that treats any expression with a '.' as an external call, and distinguish between built in functions like abi.encode, library calls, and struct field accesses. The fix should filter out non external calls by checking the call target's type.